Cursor-assisted XML validation checked a string view but forwarded the raw object. Stateful coercion could bypass the patch and restore prototype-pollution RCE.

@@ -3,6 +3,7 @@ import type { AxiosError } from 'axios'; import { parseString } from 'xml2js'; +import { removeCircularRefs, sanitizeXmlName } from '../utils'; import { NodeError } from './abstract/node.error'; import type { ErrorLevel } from '@n8n/errors'; import {

@@ -19,7 +20,6 @@ import type { 	Functionality, 	RelatedExecution, } from '../interfaces';-import { removeCircularRefs } from '../utils';  export interface NodeOperationErrorOptions { 	message?: string;@@ -275,16 +275,24 @@ export class NodeApiError extends NodeError { 	}  	private setDescriptionFromXml(xml: string) {-		parseString(xml, { explicitArray: false }, (_, result) => {-			if (!result) return;--			const topLevelKey = Object.keys(result)[0];-			this.description = this.findProperty(-				result[topLevelKey],-				POSSIBLE_ERROR_MESSAGE_KEYS,-				POSSIBLE_NESTED_ERROR_OBJECT_KEYS,-			);-		});+		parseString(

+			xml,+			{+				explicitArray: false,+				tagNameProcessors: [sanitizeXmlName],+				attrNameProcessors: [sanitizeXmlName],+			},+			(_, result) => {+				if (!result) return;

++				const topLevelKey = Object.keys(result)[0];+				this.description = this.findProperty(+					result[topLevelKey],+					POSSIBLE_ERROR_MESSAGE_KEYS,+					POSSIBLE_NESTED_ERROR_OBJECT_KEYS,+				);+			},+		); 	}  	/**

@@ -4,7 +4,7 @@ import type { 	INodeType, 	INodeTypeDescription, } from 'n8n-workflow';-import { NodeConnectionTypes, NodeOperationError, deepCopy } from 'n8n-workflow';+import { NodeConnectionTypes, NodeOperationError, deepCopy, sanitizeXmlName } from 'n8n-workflow'; import { Builder, Parser } from 'xml2js';  export class Xml implements INodeType {@@ -236,16 +236,18 @@ export class Xml implements INodeType { 		const options = this.getNodeParameter('options', 0, {});  		const forbiddenKeys = ['__proto__', 'constructor', 'prototype'];-		if (typeof options.attrkey === 'string' && forbiddenKeys.includes(options.attrkey)) {+		const attrkey = String(options.attrkey ?? '');+		const charkey = String(options.charkey ?? '');+		if (forbiddenKeys.includes(attrkey)) { 			throw new NodeOperationError( 				this.getNode(),-				`The "Attribute Key" option value "${options.attrkey}" is not allowed`,+				`The "Attribute Key" option value "${attrkey}" is not allowed`, 			); 		}-		if (typeof options.charkey === 'string' && forbiddenKeys.includes(options.charkey)) {+		if (forbiddenKeys.includes(charkey)) { 			throw new NodeOperationError( 				this.getNode(),-				`The "Character Key" option value "${options.charkey}" is not allowed`,

+				`The "Character Key" option value "${charkey}" is not allowed`, 			); 		} @@ -262,6 +264,10 @@ export class Xml implements INodeType { 							explicitArray: false,

 						}, 						options,+						{+							tagNameProcessors: [sanitizeXmlName],+							attrNameProcessors: [sanitizeXmlName],+						}, 					); 

 					const parser = new Parser(parserOptions);

@@ -6,7 +6,7 @@ import type { 	IRequestOptions, 	IHttpRequestMethods, } from 'n8n-workflow';-import { NodeApiError, NodeOperationError, sleep } from 'n8n-workflow';+import { NodeApiError, NodeOperationError, sanitizeXmlName, sleep } from 'n8n-workflow'; import { parseString } from 'xml2js';  import {

@@ -91,9 +91,17 @@ export function formatSearch(responseData: SplunkSearchResponse) {  export async function parseXml(xml: string) { 	return await new Promise((resolve, reject) => {-		parseString(xml, { explicitArray: false }, (error, result) => {-			error ? reject(error) : resolve(result);-		});+		parseString(

+			xml,+			{+				explicitArray: false,+				tagNameProcessors: [sanitizeXmlName],+				attrNameProcessors: [sanitizeXmlName],+			},+			(error, result) => {+				error ? reject(error) : resolve(result);

+			},+		); 	}); } 

@@ -236,19 +236,23 @@ export class Xml implements INodeType { 		const options = this.getNodeParameter('options', 0, {});  		const forbiddenKeys = ['__proto__', 'constructor', 'prototype'];-		const attrkey = String(options.attrkey ?? '');-		const charkey = String(options.charkey ?? '');-		if (forbiddenKeys.includes(attrkey)) {-			throw new NodeOperationError(-				this.getNode(),-				`The "Attribute Key" option value "${attrkey}" is not allowed`,-			);+		if (options.attrkey !== undefined) {+			options.attrkey = String(options.attrkey);+			if (forbiddenKeys.includes(options.attrkey)) {+				throw new NodeOperationError(+					this.getNode(),+					`The "Attribute Key" option value "${options.attrkey}" is not allowed`,+				);+			} 		}

-		if (forbiddenKeys.includes(charkey)) {-			throw new NodeOperationError(-				this.getNode(),-				`The "Character Key" option value "${charkey}" is not allowed`,-			);+		if (options.charkey !== undefined) {+			options.charkey = String(options.charkey);+			if (forbiddenKeys.includes(options.charkey)) {+				throw new NodeOperationError(+					this.getNode(),+					`The "Character Key" option value "${options.charkey}" is not allowed`,+				);+			} 		}  		let item: INodeExecutionData;