How AI contributed: Direct introductionPublished Mar 3, 2026 in 
openclaw/openclawAll 35 findings in this repository
The Synology Chat channel added in openclaw 2026.2.22 resolved its direct-message policy to allowlist by default and checked inbound senders against the configured allowed user list. That check ran through a helper which answered yes when the list was empty, so an operator who enabled the channel without naming any users got the opposite of the stated policy: the webhook accepted every sender Synology Chat delivered, and each message was dispatched to the agent with whatever tools the agent held. The released fix removes the empty-list shortcut so the helper matches nobody, and the handler now answers an empty allowlist with an explicit rejection instead of falling through to dispatch.
The Synology Chat webhook handler authorized allowlist mode through a helper that returned true whenever the allowed list was empty. With the channel's default allowlist policy and no configured users, every inbound sender cleared the authorization check and reached agent dispatch, so the agent and its tools acted on messages from senders the operator never admitted. The fix deletes the empty-list shortcut and rejects the request with an explicit authorization error before dispatch when the allowlist is empty.
Root cause
The Claude-coauthored channel addition brought in the allowlist helper that treated an empty list as a match for any sender, together with the webhook gate that used it as the sole authorization decision.
Fix
The fix drops the empty-list shortcut so the helper matches nobody, and the webhook handler now answers an empty allowlist with an explicit rejection before any dispatch.
Fix by Peter Steinberger · no AI marker found
Case facts
Claude@@ -0,0 +1,112 @@+/**+ * Security module: token validation, rate limiting, input sanitization, user allowlist.+ */++import * as crypto from "node:crypto";++/**+ * Validate webhook token using constant-time comparison.+ * Prevents timing attacks that could leak token bytes.+ */+export function validateToken(received: string, expected: string): boolean {+ if (!received || !expected) return false;++ // Use HMAC to normalize lengths before comparison,+ // preventing timing side-channel on token length.+ const key = "openclaw-token-cmp";+ const a = crypto.createHmac("sha256", key).update(received).digest();+ const b = crypto.createHmac("sha256", key).update(expected).digest();++ return crypto.timingSafeEqual(a, b);+}++/**+ * Check if a user ID is in the allowed list.+ * Empty allowlist = allow all users.+ */+export function checkUserAllowed(userId: string, allowedUserIds: string[]): boolean {+ if (allowedUserIds.length === 0) return true;+ return allowedUserIds.includes(userId);+}@@ -22,10 +22,9 @@ export function validateToken(received: string, expected: string): boolean { /** * Check if a user ID is in the allowed list.- * Empty allowlist = allow all users.+ * Allowlist mode must be explicit; empty lists should not match any user. */ export function checkUserAllowed(userId: string, allowedUserIds: string[]): boolean {- if (allowedUserIds.length === 0) return true; return allowedUserIds.includes(userId); } AI-assisted change 698c58fd8c2b877783cc5027731b7fefd3b263c605418ce4137454773d5e2f84 · Fix 3eea9439a76fdd5ffd8d69da15b499dc414a93ca5ccb6b0257593a6a87037041